Skip to content

Enable Pylint warning consider-using-ternary #51051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 30, 2023
Merged

Enable Pylint warning consider-using-ternary #51051

merged 6 commits into from
Jan 30, 2023

Conversation

uzzell
Copy link
Contributor

@uzzell uzzell commented Jan 28, 2023

Enables the Pylint type-W warning consider-using-ternary.

MarcoGorelli
MarcoGorelli approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, agree that this is much easier to read

Lgtm pending green

topper-123
topper-123 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these are a lot nicer to read.

@mroeschke mroeschke added this to the 2.0 milestone Jan 30, 2023
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Jan 30, 2023
@mroeschke mroeschke merged commit 8983b55 into pandas-dev:main Jan 30, 2023
@mroeschke
Copy link
Member

Thanks @uzzell

jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Jan 30, 2023
@uzzell @MarcoGorelli @jbrockmendel
Enable Pylint warning consider-using-ternary (pandas-dev#51051)
d0cb1be 
* Enable the Pylint check "consider-using-ternary"

* Reformat file

* Fix error in ternary statement

---------

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@topper-123 topper-123 topper-123 approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@uzzell @mroeschke @topper-123 @MarcoGorelli